add options in base install #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francocatena
reviewed
Feb 6, 2021
| @@ -1,11 +0,0 @@ | |||
| deployer ALL= NOPASSWD: /bin/systemctl start unicorn | |||
There was a problem hiding this comment.
No lo borraría a eso, si vemos que el usuario está creado no lo metemos, caso contrario si.
base/install_app_base.sh
Outdated
| dir_nginx=/etc/nginx | ||
|
|
||
| echo "Instalación Paquete NGINX" | ||
| #echo "Instalación Paquete NGINX" |
There was a problem hiding this comment.
Todos estos echo comentados, los pasaría a comentarios normales y en inglés.
base/install_app_base.sh
Outdated
Comment on lines
12
to
25
| while getopts u:p: option | ||
| do | ||
| case "${option}" in | ||
| u) user=${OPTARG};; | ||
| p) mawidabp_path=${OPTARG};; | ||
| :) echo "INVALID";; | ||
| \?) echo "Argumento -${option} erroneo use: | ||
| [u] Nombre de usuario | ||
| [p] Directorio de instalacion | ||
| " | ||
| exit;; | ||
|
|
||
| esac | ||
| done |
There was a problem hiding this comment.
Esto se suele poner así:
while getopts u:p: option; do
case $option in
esac
doneY el :) se le pone el mensaje "requiere un argumento". También se pone en eso dos casos un exit 1, así indicás error.
base/install_app_base.sh
Outdated
|
|
||
| esac | ||
| done | ||
| shift $((OPTIND -1)) |
francocatena
reviewed
Feb 6, 2021
base/install_app_base.sh
Outdated
Comment on lines
80
to
81
| #adduser deployer -G nginx | ||
| #passwd deployer |
There was a problem hiding this comment.
Acá haría lo que hablamos, todo esto en un if si no existe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.